Merged
Conversation
Contributor
Author
|
Depends on #74. |
saiarcot895
force-pushed
the
fix-errors-for-newer-python
branch
from
98abd91 to
5226e2b
Compare
Contributor
Author
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
force-pushed
the
fix-errors-for-newer-python
branch
2 times, most recently
from
c221a5d to
d5d2cd8
Compare
saiarcot895
force-pushed
the
fix-errors-for-newer-python
branch
8 times, most recently
from
7dd3210 to
bd6baa7
Compare
saiarcot895
changed the title
saiarcot895
force-pushed
the
fix-errors-for-newer-python
branch
from
bd6baa7 to
70c0fed
Compare
…or DualToR config (sonic-net#82) This PR is a required for changing the L3 IP forwarding Behavior to SoC in active-active toplogy. Basically a src IP is added to the SNAT rule so that only packets originating from ToR with src IP as vlan IP get natted by the rule and change the src IP to LoopBack IP However if there are mutiple vlan IP's we only add the source IP as vlan IP, for which the SoC IP belongs to, this PR adds that change. How I did it check the config DB if the ToR is a DualToR and has an SoC IP assigned. put an iptable rule iptables -t nat -A POSTROUTING --destination -j SNAT --to-source " Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Newer versions of pip/setuptools don't support test_requires, and the current standard is to specify any extra dependencies (such as those required for testing) under extra_requires. Therefore, specify the testing dependencies under extra_requires. These can be installed via pip using `pip install '.[testing]'`. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
force-pushed
the
fix-errors-for-newer-python
branch
from
70c0fed to
dacb526
Compare
Debian Bookworm has removed libpam-cracklib; replace with libpam-pwquality. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
This repo's tests depends on files that are in src/sonic-host-services-data in sonic-buildimage. Due to PR check requirements, this creates a cyclical dependency when needing to update the templates and the sample output files. To fix that cyclical dependency, move that directory into this repo. That way, both the templates and the sample output files can be updated in a single commit. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Contributor
Author
|
@liushilongbuaa would you be able to review the pipeline-related changes here? This is removing a dependency on sonic-buildimage so that a cyclical dependency is broken. |
liushilongbuaa
previously approved these changes
Nov 6, 2023
Contributor
liushilongbuaa
left a comment
liushilongbuaa
left a comment
There was a problem hiding this comment.
LGTM.
Take care for submodule HEAD updation.
saiarcot895
force-pushed
the
fix-errors-for-newer-python
branch
from
dacb526 to
db4bbf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Python dependency list and test code for Bookworm, and break a cyclical dependency between this repo and sonic-buildimage.
For Python package builds, newer versions of pip/setuptools don't support test_requires, and the current standard is to specify any extra dependencies (such as those required for testing) under extra_requires. Therefore, specify the testing dependencies under extra_requires. These can be installed via pip using
pip install '.[testing]'.In the PAM config files, replace libpam-cracklib with libpam-pwquality, since the former has been removed from Bookworm.
Finally, updating PAM config files currently causes a cyclical dependency, since the templates are in sonic-buildimage, but the test output files are in this repo. This would mean that in order to make a change in the template that would affect the output, PR checks would fail. Fix this by moving the template files into this repo. References to the template files in sonic-buildimage would need to be updated to point to the files in sonic-host-services.